Skip to content

Removes old products from the upgrades page.#22367

Merged
vraja-pro merged 3 commits intorelease/25.4from
remove-old-products
Jun 18, 2025
Merged

Removes old products from the upgrades page.#22367
vraja-pro merged 3 commits intorelease/25.4from
remove-old-products

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Jun 18, 2025

Context

  • Removes some products from the upgrades page.

Summary

This PR can be summarized in the following changelog entry:

  • Removes some products from the upgrades page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure you don't have WooCommerce installed.

  • Go to /wp-admin/admin.php?page=wpseo_licenses and make sure you see only premium.

  • Install WooCommerce and go to /wp-admin/admin.php?page=wpseo_licenses make sure you now also see the Woo Add-on card.

  • On multisite also do the above steps to make sure it works.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the 25.4 milestone Jun 18, 2025
@thijsoo thijsoo added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog fix-before-release labels Jun 18, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 18, 2025

Pull Request Test Coverage Report for Build ce22057b0c7f5798220965262ddbb2beec150eb7

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 53.209%

Changes Missing Coverage Covered Lines Changed/Added Lines %
admin/views/licenses.php 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
admin/views/licenses.php 1 0.0%
Totals Coverage Status
Change from base Build c5210f0557c088626164ab275329fbc5fd3bb809: -0.4%
Covered Lines: 29826
Relevant Lines: 56978

💛 - Coveralls

@vraja-pro vraja-pro self-assigned this Jun 18, 2025
@vraja-pro
Copy link
Copy Markdown
Contributor

CR & AC ✅

@vraja-pro vraja-pro merged commit a33f312 into release/25.4 Jun 18, 2025
26 checks passed
@vraja-pro vraja-pro deleted the remove-old-products branch June 18, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog fix-before-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants