Adds support for optional label in the checkbox component#22372
Merged
igorschoester merged 3 commits intotrunkfrom Jun 25, 2025
Merged
Adds support for optional label in the checkbox component#22372igorschoester merged 3 commits intotrunkfrom
igorschoester merged 3 commits intotrunkfrom
Conversation
Pull Request Test Coverage Report for Build ae9695c6802ca06686f786cc62d1c2381fc99b70Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
igorschoester
approved these changes
Jun 23, 2025
Contributor
igorschoester
left a comment
There was a problem hiding this comment.
CR && AT ✅
Can merge, but two remarks:
- A story where we mention adding
aria-labelinstead of passing a label - You fixed the default argument and JSDoc for
className, but thedisabledis also missing 😇
Good to merge regardless, so leaving whether you want to do anything about the above to you.
8340951 to
25c610d
Compare
igorschoester
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
For developers
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #