Announce the addition of the Google docs add on to Free & Premium #4603

[mykola]

Show Announce modal only for Yoast Admin pages.

Context

• Shows announce of the Google Docs add-on only on Yoast Settings page.

Summary

This PR can be summarized in the following changelog entry:

• Fixes a bug where the Google Docs add-on announcement modals appeared on all admin pages.

Relevant technical choices:

• Use conditional class to show only on YOast Settings page.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Free.

• Deactivate Yoast Premium plugin if it's active.
• Deactivate the free plugin.
• Open any sql editor or use wp db query wp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:
  DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions'
• Activate the free plugin.
• Make sure that the dialog not displayed.
• Go to Yoast Settings page.
• Make sure that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed and fit the design:
  
• Click on Unlock with Yoast SEO Premium button and make sure that url is opened in new tab (the pages should be created and active before tests).

Check that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed in for Premium.

• Activate Yoast Premium plugin.
• Install previous version of Free plugin (or just build from trunk if it's not merged yet)
• Open any sql editor or use wp db query wp-cli command and remove _yoast_wpseo_introductions meta_key from wp_usermeta table:
  DELETE FROM `wp_usermeta` WHERE `meta_key` = '_yoast_wpseo_introductions'
• Upgrade free plugin to the current version from this PR.
• Make sure that the dialog not displayed.
• Navigate to Yoast Settings page.
• Make sure that Yoast SEO Google Docs Add-On - incl. in Premium upsell modal is displayed and fit the design:
  
• Click on Get started for free button and make sure that url is opened in new tab (the pages should be created and active before tests).

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

• No other impact.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #4603

[coveralls]

Pull Request Test Coverage Report for Build b0d96a1968c1e2a4deeb4ffed42322481bcd1e3d

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• 30 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.008%) to 53.885%

---

Files with Coverage Reduction	New Missed Lines	%
inc/class-post-type.php	2	68.42%
src/helpers/post-type-helper.php	3	17.86%
src/llms-txt/infrastructure/markdown-services/content-types-collector.php	25	72.53%

Totals
Change from base Build 7f13637735c91788cfc2d1721395816a9e9168c3:	-0.008%
Covered Lines:	30487
Relevant Lines:	57543

---

💛 - Coveralls

[JorPV]

Just a small adjustment :)

[JorPV]

@mykola there is an error comming form the safeCreateInterpolateElement() function.

[JorPV]

It looks good to me! 👍🏼