641 create the dropdowns for the manual page selection#22388
Merged
igorschoester merged 20 commits intofeature/llms-txt-phase-2from Jul 3, 2025
Merged
Conversation
…ropdowns-for-the-manual-page-selection
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
…e's none selected
…-for-the-manual-page-selection
…-for-the-manual-page-selection
Pull Request Test Coverage Report for Build e257b438628e2f690e1d6a8317ff42059e2883bfDetails
💛 - Coveralls |
c651d99 to
4f32217
Compare
4f32217 to
60f432e
Compare
b5ffdd0 to
40963d6
Compare
igorschoester
suggested changes
Jul 3, 2025
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Known limitations of this first iteration:
/pagerequest is still going, clicking an empty dropdown to add a page, doesn't give you a list of pages to choose from or a loading state. And as soon as the/pagerequest is done, then suddenly you get a list of pages to choose from. Basically, a lack of loading state when the initial `/page request is still going.page not foundmessage while it searches, until you finish typing. When you finish typing, after a while you're greeted with the list of pages that are satisfying the search term./pagerequest fails, there's no errored UX and the user is left guessingNoneoption in the dropdown where they had selected a now-deleted page./pageroute. We intend to change that here.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
wpseo_llmstxtoption, run it through https://www.unserialize.com/ and confirm that theother_included_pagessubsetting is an array that only contains valid page IDs.wpseo_llmstxtoption, run it through https://www.unserialize.com/ and confirm that theother_included_pagessubsetting is an array that only contains valid page IDs.Xat the right of the dropdown. Then save. Confirm after a page load, that you only get a single empty dropdown. Find in the DB, thewpseo_llmstxtoption, run it through https://www.unserialize.com/ and confirm that theother_included_pagessubsetting is an array that only contains valid page IDs.Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #