Also add the plans page when on the frontend

[igorschoester]

Context

Summary

This PR can be summarized in the following changelog entry:

• Fixes an unreleased bug where the Plans page would not have a link in the Yoast menu on the frontend.

Relevant technical choices:

• No conditionals is fine?

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Crucial fix:

• Verify Plans is present in the WP admin bar menu (under SEO Settings) while on the frontend
• Verify Plans is present in the WP admin bar menu (under SEO Settings) while on the frontend of a multisite site

Can't hurt to check (again):

• Verify Plans is present in the WP admin bar menu (under SEO Settings)
• Verify Plans is present in the WP admin bar menu (under SEO Settings) of a multisite
• Verify Plans is present in the WP admin bar menu (under SEO Settings) on the network admin of a multisite
• Verify Plans is present in the Yoast admin menu
• Verify Plans is present in the Yoast admin menu on a multisite
• Verify Plans is present in the Yoast admin menu on the network admin of a multisite

Extra safety test:
Due to the no conditionals, always running, it makes sense to me to verify there is no issue in other requests like AJAX.

• Visiting our dashboard triggers a AJAX GET for the scores, you could even search for a term to trigger more
• Changing something in our first time configuration does a AJAX POST to save

Smoke test to be very safe:
Follow the other instructions from #22374

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• No conditionals,

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 03d2c00d015f078fda2e3ffea549bd9ecf401a96

Details

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 53.403%

---

Totals
Change from base Build 4291a0e150ca1e565ed133701f0139462229355d:	-0.5%
Covered Lines:	29980
Relevant Lines:	57014

---

💛 - Coveralls

[vraja-pro]

CR & AC ✅