Conversation
Pull Request Test Coverage Report for Build 2651e113d3b5014200fcee579a9723355686ffc6Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
vraja-pro
left a comment
There was a problem hiding this comment.
CR 🚧
- In some class
coverannotation is used in the method level and the class level and that generated a warning. Remove that cover annotation on the method level and the extra space, and that would resolve the warnings. - Some methods are not covered, so either mention in the Technical debt section why or add coverage:
- Consent_Route::consent
- Consent_Route::check_permissions
- Ai_Consent_Integration::get_script_data
Thanks @vraja-pro, all the suggestions are applied now. |
@vraja-pro Thanks, added 🙂 |

Context
Summary
This PR can be summarized in the following changelog entry:
src/ai-consentdirectory.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes https://github.com/Yoast/reserved-tasks/issues/617