Skip to content

Makes sure that the indexables api request only fires when needed.#22418

Merged
igorschoester merged 2 commits intofeature/llms-txt-phase-2from
667-nice-to-have-going-into-the-llmstxt-settings-page-fires-a-pages-request-even-if-the-feature-is-disabled
Jul 14, 2025
Merged

Makes sure that the indexables api request only fires when needed.#22418
igorschoester merged 2 commits intofeature/llms-txt-phase-2from
667-nice-to-have-going-into-the-llmstxt-settings-page-fires-a-pages-request-even-if-the-feature-is-disabled

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Jul 9, 2025

Context

  • We don't want to fire an API request when its not needed.

Summary

This PR can be summarized in the following changelog entry:

  • Makes sure the available_posts call is only fired when needed.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure the llms.txt feature is set to automatic.
  • Disable the llms.txt feature and save.
  • Refresh and make sure that in the network tab no call is done to available_posts.
  • Enable the feature and make sure no request is fired.
  • Refresh and make sure that in the network tab no call is done to available_posts.
  • Set the selection method to Manual and make sure the request is fired. Toggle it back and forth between Manual and Automatic and make sure no other requests are fired.
  • Save and refresh. Make sure that the request is fired on page load.
  • Toggle the disable and enable of the feature and make sure no other requests are fired.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the feature/llms-txt-phase-2 milestone Jul 9, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 9, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 9, 2025

Pull Request Test Coverage Report for Build 2385e82d37e44a682b63293276773c15ec58bc3e

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 64 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 53.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/settings/routes/llms-txt.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/settings/helpers/search.js 6 15.0%
packages/js/src/settings/store/index.js 6 0.0%
packages/js/src/settings/routes/site-features.js 13 0.0%
packages/js/src/settings/app.js 15 0.0%
packages/js/src/settings/initialize.js 24 0.0%
Totals Coverage Status
Change from base Build f84a8ac44b0411b1a4b1db1c6c4fff6b506aff62: 0.3%
Covered Lines: 30497
Relevant Lines: 57929

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

…-seo into 667-nice-to-have-going-into-the-llmstxt-settings-page-fires-a-pages-request-even-if-the-feature-is-disabled

# Conflicts:
#	packages/js/src/settings/routes/llms-txt.js
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit 9e85836 into feature/llms-txt-phase-2 Jul 14, 2025
20 checks passed
@igorschoester igorschoester deleted the 667-nice-to-have-going-into-the-llmstxt-settings-page-fires-a-pages-request-even-if-the-feature-is-disabled branch July 14, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants