Skip to content

Disable relevant settings when pages are noindexed and/or disabled from indexables#22420

Merged
igorschoester merged 5 commits intofeature/llms-txt-phase-2from
661-deal-with-the-case-of-pages-being-disabled-from-indexables
Jul 10, 2025
Merged

Disable relevant settings when pages are noindexed and/or disabled from indexables#22420
igorschoester merged 5 commits intofeature/llms-txt-phase-2from
661-deal-with-the-case-of-pages-being-disabled-from-indexables

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Jul 9, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Disables relevant settings when pages are noindexed and/or disabled from indexables.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Yoast settings->Content types->Pages and disable the Show pages in search results setting
  • Go to Yoast settings->llms.txt and confirm that the settings below the main one are disabled and a relevant alert is shown:
    image
  • If you enable the Show pages in search results setting, the llms.txt settings are enabled and the alert is hidden
  • When the Show pages in search results setting is disabled, no matter what you had selected in the llms.txt settings, you will not get pages in the file when that's generated
  • Repeat the same but instead of the Show pages in search results setting, add the following filter that disables indexables:
add_filter( 'wpseo_indexable_excluded_post_types', 'exclude_page' );
function exclude_page( ) {
	return ['page'];
}
  • In this case, the disabled from being shown in the search results link points to the main settings pages, but it's ok because disabling pages via filter is an edge case anyway.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 9, 2025
@leonidasmi leonidasmi added this to the feature/llms-txt-phase-2 milestone Jul 9, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 9, 2025

Pull Request Test Coverage Report for Build 8aec929143299fba4e3b4edb1043f25e734c2c10

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 661-deal-with-the-case-of-pages-being-disabled-from-indexables at 41.42%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/settings/store/llms-txt.js 0 1 0.0%
src/llms-txt/application/configuration/llms-txt-configuration.php 0 3 0.0%
packages/js/src/settings/routes/llms-txt.js 0 8 0.0%
Totals Coverage Status
Change from base Build 2de329ec8556e60faca1007d85c5714fa42d0e25: 41.4%
Covered Lines: 20937
Relevant Lines: 47881

💛 - Coveralls

@leonidasmi leonidasmi marked this pull request as ready for review July 10, 2025 06:47
Comment thread packages/js/src/settings/routes/llms-txt.js Outdated
Co-authored-by: Igor <35524806+igorschoester@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit 60a0f7a into feature/llms-txt-phase-2 Jul 10, 2025
36 checks passed
@igorschoester igorschoester deleted the 661-deal-with-the-case-of-pages-being-disabled-from-indexables branch July 10, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants