Skip to content

Add unit tests for the llms-txt configuration#22431

Merged
vraja-pro merged 4 commits intotrunkfrom
add/unit-tests-llms-txt-config
Jul 16, 2025
Merged

Add unit tests for the llms-txt configuration#22431
vraja-pro merged 4 commits intotrunkfrom
add/unit-tests-llms-txt-config

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Jul 15, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds unit tests for the llms-txt configuration.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

QA can test this PR by following these steps:

  • N/A

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • None

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 15, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 15, 2025

Pull Request Test Coverage Report for Build 5879e5a50f47b9dc7f0ae637458a78fa97f9b0f8

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.9%) to 52.779%

Files with Coverage Reduction New Missed Lines %
admin/tracking/class-tracking-settings-data.php 7 0.0%
inc/options/class-wpseo-option-wpseo.php 18 86.49%
src/helpers/current-page-helper.php 23 74.31%
Totals Coverage Status
Change from base Build a2bd7e124e8fda2c486937b59f8a306770f2e0af: -0.9%
Covered Lines: 30181
Relevant Lines: 58203

💛 - Coveralls

@vraja-pro vraja-pro self-assigned this Jul 16, 2025
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
If we mock the variable, lets mention it in the type

leonidasmi and others added 3 commits July 16, 2025 11:15
Co-authored-by: Vraja Das <65466507+vraja-pro@users.noreply.github.com>
Co-authored-by: Vraja Das <65466507+vraja-pro@users.noreply.github.com>
Co-authored-by: Vraja Das <65466507+vraja-pro@users.noreply.github.com>
@leonidasmi leonidasmi removed their assignment Jul 16, 2025
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the 25.7 milestone Jul 16, 2025
@vraja-pro vraja-pro merged commit 691c5ee into trunk Jul 16, 2025
27 checks passed
@vraja-pro vraja-pro deleted the add/unit-tests-llms-txt-config branch July 16, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants