Skip to content

Include RC suffix in version compare#22437

Merged
pls78 merged 2 commits intorelease/25.6from
2417-blocker-256-use-ai-btn-is-not-displayed
Jul 16, 2025
Merged

Include RC suffix in version compare#22437
pls78 merged 2 commits intorelease/25.6from
2417-blocker-256-use-ai-btn-is-not-displayed

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jul 16, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Takes into account the RC part of the version number when comparing it.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install and activate Free SEO 25.6-RC2 + Premium 25.6-RC1
  • Create a new post
  • Check you see the "Use AI" button for SEO Title/Description
  • Now downgrade Premium to a previous version, like 25.4
  • Check you still see the "Use AI" button for SEO Title/Description

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2417

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 16, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 16, 2025

Pull Request Test Coverage Report for Build 5f21fd8a5b36c721e3f8049cc361e283fe7bfe9c

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 52.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/conditionals/ai-editor-conditional.php 0 2 0.0%
Totals Coverage Status
Change from base Build 701937920c8e99451d6c7529be97335e8992b0d2: -0.5%
Covered Lines: 30428
Relevant Lines: 59121

💛 - Coveralls

@pls78 pls78 added this to the 25.6 milestone Jul 16, 2025
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 5a1a04c into release/25.6 Jul 16, 2025
28 checks passed
@pls78 pls78 deleted the 2417-blocker-256-use-ai-btn-is-not-displayed branch July 16, 2025 08:20
@pls78 pls78 changed the title exclude RC suffix for version compare Include RC suffix in version compare Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants