Conversation
Pull Request Test Coverage Report for Build d0fc1281b9b24f54c203cd93a4ab9a1da87701deWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
77469ce to
b982687
Compare
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
|
@pls78 please resolve merge conflicts. |
b982687 to
2d5c5ad
Compare
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
0b4fb2e to
41afe20
Compare
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
0e8310c to
3d10235
Compare
vraja-pro
left a comment
There was a problem hiding this comment.
There were 55 warnings:
-
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Build_Suggestions_Array_Test::test_build_suggestions_array
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::build_suggestions_array" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Build_Suggestions_Array_Test::test_build_suggestions_array_with_empty_api_response
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::build_suggestions_array" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Get_Suggestions_Test::test_get_suggestions
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Get_Suggestions_Test::test_get_suggestions_with_unauthorized_exception with data set "Retry on unauthorized" (true)
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Get_Suggestions_Test::test_get_suggestions_with_unauthorized_exception with data set "Do not retry on unauthorized" (false)
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Application\Suggestions_Provider\Get_Suggestions_Test::test_get_suggestions_with_forbidden_exception
"@Covers \Yoast\WP\SEO\AI_Generator\Application\Suggestions_Provider::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Domain\Suggestion\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI_Generator\Domain\Suggestion::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Domain\Suggestion\Get_Value_Test::test_get_value
"@Covers \Yoast\WP\SEO\AI_Generator\Domain\Suggestion::get_value" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Domain\Suggestions_Bucket\Add_Suggestion_Test::test_add_suggestion
"@Covers \Yoast\WP\SEO\AI_Generator\Domain\Suggestions_Bucket::add_suggestion" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Domain\Suggestions_Bucket\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI_Generator\Domain\Suggestions_Bucket::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Domain\Suggestions_Bucket\To_Array_Test::test_to_array
"@Covers \Yoast\WP\SEO\AI_Generator\Domain\Suggestions_Bucket::to_array" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Suggestions_Endpoint\Get_Name_Test::test_get_name
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Suggestions_Endpoint::get_name" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Suggestions_Endpoint\Get_Namespace_Test::test_get_namespace
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Suggestions_Endpoint::get_namespace" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Suggestions_Endpoint\Get_Route_Test::test_get_route
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Suggestions_Endpoint::get_route" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Suggestions_Endpoint\Get_Url_Test::test_get_url
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Suggestions_Endpoint::get_url" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Usage_Endpoint\Get_Name_Test::test_get_name
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Usage_Endpoint::get_name" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Usage_Endpoint\Get_Namespace_Test::test_get_namespace
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Usage_Endpoint::get_namespace" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Usage_Endpoint\Get_Route_Test::test_get_route
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Usage_Endpoint::get_route" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\Endpoints\Get_Usage_Endpoint\Get_Url_Test::test_get_url
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\Endpoints\Get_Usage_Endpoint::get_url" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\WordPress_URLs\Get_Callback_Url_Test::test_get_callback_url
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\WordPress_URLs::get_callback_url" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\WordPress_URLs\Get_License_Url_Test::test_get_license_url
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\WordPress_URLs::get_license_url" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\Infrastructure\WordPress_URLs\Get_Refresh_Callback_Url_Test::test_get_refresh_callback_url
"@Covers \Yoast\WP\SEO\AI_Generator\Infrastructure\WordPress_URLs::get_refresh_callback_url" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Bust_Subscription_Cache_Route\Bust_Subscription_Cache_Test::test_bust_subscription_cache
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Bust_Subscription_Cache_Route::bust_subscription_cache" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Bust_Subscription_Cache_Route\Conditional_Test::test_conditional
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Bust_Subscription_Cache_Route::get_conditionals" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Bust_Subscription_Cache_Route\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Bust_Subscription_Cache_Route::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Bust_Subscription_Cache_Route\Register_Routes_Test::test_register_routes
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Bust_Subscription_Cache_Route::register_routes" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Generator_Integration\Conditional_Test::test_conditional
"@Covers \Yoast\WP\SEO\AI\Generator\User_Interface\Generator_Integration::get_conditionals" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Generator_Integration\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI\Generator\User_Interface\Generator_Integration::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Generator_Integration\Enqueue_Assets_Test::test_enqueue_assets
"@Covers \Yoast\WP\SEO\AI\Generator\User_Interface\Generator_Integration::enqueue_assets" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Generator_Integration\Get_Product_Subscriptions_Test::test_get_product_subscriptions
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\AI_Generator_Integration::get_product_subscriptions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Generator_Integration\Get_Script_Data_Test::test_get_script_data
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Generator_Integration::get_script_data" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Generator_Integration\Register_Hooks_Test::test_register_hooks
"@Covers \Yoast\WP\SEO\AI\Generator\User_Interface\Generator_Integration::register_hooks" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Suggestions_Route\Conditional_Test::test_conditional
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Suggestions_Route::get_conditionals" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Suggestions_Route\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Suggestions_Route::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Suggestions_Route\Get_Suggestions_Test::test_get_suggestions
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Suggestions_Route::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Suggestions_Route\Get_Suggestions_Test::test_get_suggestions_with_missing_license
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Suggestions_Route::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Suggestions_Route\Get_Suggestions_Test::test_get_suggestions_with_runtime_exception
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Suggestions_Route::get_suggestions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Suggestions_Route\Register_Routes_Test::test_register_routes
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Suggestions_Route::register_routes" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Conditional_Test::test_conditional
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_conditionals" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Constructor_Test::test_constructor
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::__construct" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "is Woo product, has valid Woo subscription, has Premium subscription" (true, true, true, '/usage/2025-09')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "is Woo product, has valid Woo subscription, no Premium subscription" (true, true, false, '/usage/2025-09')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "is Woo product, no valid Woo subscription, has valid Premium subscription" (true, false, true, '/usage/free-usages')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "is Woo product, no valid Woo subscription, no valid Premium subscription" (true, false, false, '/usage/free-usages')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "not Woo product, has valid Woo subscription, has Premium subscription" (false, true, true, '/usage/2025-09')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "not Woo product, has valid Woo subscription, no Premium subscription" (false, true, false, '/usage/free-usages')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "not Woo product, no valid Woo subscription, has valid Premium subscription" (false, false, true, '/usage/2025-09')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Action_Path_Test::test_get_action_path with data set "not Woo product, no valid Woo subscription, no valid Premium subscription" (false, false, false, '/usage/free-usages')
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_action_path" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Usage_Test::test_get_usage
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_usage" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Usage_Test::test_get_usage_with_bad_http_request
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_usage" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Get_Usage_Test::test_get_usage_with_too_many_requests_exception
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::get_usage" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Get_Usage_Route\Register_Routes_Test::test_register_routes
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Get_Usage_Route::register_routes" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Route_Permission_Trait\Check_Permissions_Test::test_check_permissions with data set "Logged out" (0, false)
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Route_Permission_Trait::check_permissions" is invalid -
Yoast\WP\SEO\Tests\Unit\AI\Generate\User_Interface\Route_Permission_Trait\Check_Permissions_Test::test_check_permissions with data set "Logged in" (1, true)
"@Covers \Yoast\WP\SEO\AI_Generator\User_Interface\Route_Permission_Trait::check_permissions" is invalid
|
Do we want that in 26.0 release? |
I don't think so, no. |
|
AC 🚧 |
b4b4822 to
1924e01
Compare
Context
AI OptimizeandAI Summarizefeatures._deprecated_functionaccording to the release this PR will be part of.Summary
This PR can be summarized in the following changelog entry:
aiparent directory and consequently losing theAI_namespace/class prefixRelevant technical choices:
AI_prefix and are now under anaiparent directory.Endpoint_ListandEndpoints_Repositoryclasses have been moved tosrc/routes/endpointdirectory, so that they can be re-used throughout the codebase and not being re-declared each time.Consent_Endpoint_Interface,Free_Sparks_Endpoint_Interface,Generator_Endpoint_Interfacehave been introduced to let our DI container know which endpoints need to be gathered by the respective repository. As a result, they are attached to the respective integration window object in theendpointproperty (exception made for the Free Sparks one, which is bundled in thewpseoAiGeneratorwindow object.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #