Skip to content

Show focus keyphrase error message without ai consent#22444

Merged
enricobattocchi merged 1 commit intorelease/25.6from
2420-major256-validation-msg-for-keyphrase-is-not-displayed-on-use-ai
Jul 18, 2025
Merged

Show focus keyphrase error message without ai consent#22444
enricobattocchi merged 1 commit intorelease/25.6from
2420-major256-validation-msg-for-keyphrase-is-not-displayed-on-use-ai

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

We want to check the error message before asking for consent.

Context

Summary

This PR can be summarized in the following changelog entry:

  • Show error message for the missing focus keyphrase before giving consent for the ai feature.

Relevant technical choices:

  • We decided to do that before consent because we have the upsell before the consent and we want to reduce steps between the upsell modal appears and the ai generator modal.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure you revoked consent or didn't grant it for the ai feature.
  • Edit a post without focus keyphrase.
  • Click on "Use AI" button.
  • Check you the focus is on the focus keyphrase field and there is an error message:
Screenshot 2025-07-18 at 11 33 02

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes [Major]25.6: Validation msg for keyphrase is not displayed on Use AI

We want to check the error message before asking for consent.
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 18, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 28cbdb97917d8e2f0fab423bba8b91666861ae7c

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 52.585%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/initialize/filter-focus-keyphrase-errors.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/ai-generator/initialize/filter-focus-keyphrase-errors.js 1 0.0%
Totals Coverage Status
Change from base Build a8368e1366f33338b31f7ae809d3512e1d93b7ab: 0.0%
Covered Lines: 30934
Relevant Lines: 59652

💛 - Coveralls

@vraja-pro vraja-pro changed the title show error message even without consent Show focus keyphrase error message without ai consent Jul 18, 2025
@enricobattocchi enricobattocchi merged commit 267c88d into release/25.6 Jul 18, 2025
21 checks passed
@enricobattocchi enricobattocchi deleted the 2420-major256-validation-msg-for-keyphrase-is-not-displayed-on-use-ai branch July 18, 2025 10:13
@agnieszkaszuba agnieszkaszuba added this to the 25.6 milestone Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants