Skip to content

remove bundle upsell link from the subscription error#22453

Merged
pls78 merged 1 commit intotrunkfrom
686-remove-bundle-link-from-ai-subscription-error
Jul 28, 2025
Merged

remove bundle upsell link from the subscription error#22453
pls78 merged 1 commit intotrunkfrom
686-remove-bundle-link-from-ai-subscription-error

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jul 24, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes the Yoast WooCommerce SEO and Premium bundle upsell link from the AI Generate subscription error modal.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure you don't have premium and woo seo license.
  • Install and activate Woocommerce.
  • Install and activate Woo seo and premium.
  • Edit a product and click on the "Use AI" button.
  • Check you get the error message with an upsell link only for woo SEO.
  • Enable subscription for Woo SEO.
  • Click on Use AI, and check you are getting an subscription error for Premium.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Remove bundle link from AI subscription error

@vraja-pro vraja-pro added UI change PRs that result in a change in the UI changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Jul 24, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2b0947c6f76418a4c053ff462027cc8657dc814b

Details

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 52.69%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-generator/components/errors/subscription-error.js 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/ai-generator/components/errors/subscription-error.js 2 7.14%
Totals Coverage Status
Change from base Build d7b01156aa0f318471173d47c8ac223ff87c0f1d: 0.5%
Covered Lines: 31002
Relevant Lines: 59627

💛 - Coveralls

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 added this to the 25.7 milestone Jul 28, 2025
@pls78 pls78 merged commit 9980432 into trunk Jul 28, 2025
23 checks passed
@pls78 pls78 deleted the 686-remove-bundle-link-from-ai-subscription-error branch July 28, 2025 10:03
@pls78 pls78 changed the title remove budle upsell link from the subscription error remove bundle upsell link from the subscription error Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog UI change PRs that result in a change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants