Skip to content

616 add unit tests for ai authorization#22456

Merged
pls78 merged 10 commits intotrunkfrom
616-add-unit-tests-for-ai-authorization
Aug 26, 2025
Merged

616 add unit tests for ai authorization#22456
pls78 merged 10 commits intotrunkfrom
616-add-unit-tests-for-ai-authorization

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jul 25, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds a safety check when check AI token expiration.
  • Adds tests to the Token manager and Code verifier handler classes for the AI authorization.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test ai generator, try to generate title and description.

For developers

  • Check there is 100% coverage by producing the html report, execute:
    • composer update yoast/wp-test-utils --with-dependencies --ignore-platform-req=php
    • Produce the report with the command ./vendor/bin/phpunit --coverage-html ~/Desktop/ai-authorization
    • Open the index.html in the new ai-authorization on your Desktop.
    • Navigate to src->ai-authorization->application
    • Check token manger and Code verifier handler are 100% covered (green).
  • Run the tests using the command composer test and check you get no errors or warnings for Ai_Authorization.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/693

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 25, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5570054200a250f3facb2cdfb4cedecc06e816ee

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 52.317%

Totals Coverage Status
Change from base Build ffaeae46693c81847ff6dc05579da9a295d34cc8: -0.3%
Covered Lines: 30604
Relevant Lines: 59143

💛 - Coveralls

Copy link
Copy Markdown
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@pls78 pls78 added this to the 25.9 milestone Aug 26, 2025
@pls78 pls78 merged commit 53e7161 into trunk Aug 26, 2025
29 checks passed
@pls78 pls78 deleted the 616-add-unit-tests-for-ai-authorization branch August 26, 2025 08:42
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants