Skip to content

Fix main modal help link prop#22462

Merged
igorschoester merged 1 commit intorelease/25.6from
fix-help-link-in-error-modal
Jul 28, 2025
Merged

Fix main modal help link prop#22462
igorschoester merged 1 commit intorelease/25.6from
fix-help-link-in-error-modal

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jul 28, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes the link in the AI generator error modal.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable Premium without subscription.
  • Edit a post and click on "Use AI".
  • Check you are getting a subscription error.
  • Click on the question mark and check you are redirected to the help link https://yoast.com/help/faq-ai-in-yoast-seo with parameters in the url like:
    https://yoast.com/help/faq-ai-in-yoast-seo/#utm_medium=software&utm_source=yoast-seo&utm_term=ai-support&utm_content=support-link&php_version=8.2&platform=wordpress&platform_version=6.8.2&software=premium&software_version=25.6-RC7&days_active=20297&shortlink=ai-generator-help-button-modal
  • Enable the subscription or disable premium
  • Edit a post
  • Click on "use AI"
  • Click on the question mark and check you are redirected to the help link https://yoast.com/help/faq-ai-in-yoast-seo with the params as above.
Screenshot_2025-07-28_at_10_42_49 Screenshot_2025-07-28_at_10_42_10

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2434

@vraja-pro vraja-pro added this to the 25.6 milestone Jul 28, 2025
@vraja-pro vraja-pro added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog fix-before-release labels Jul 28, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build c8f3327fc1b260723ccc1b42ae3a392d76f8576d

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.562%

Totals Coverage Status
Change from base Build efad52012a6ae81a0eeaead28da73b10f67ba3ca: 0.0%
Covered Lines: 30935
Relevant Lines: 59662

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit ac6f199 into release/25.6 Jul 28, 2025
23 checks passed
@igorschoester igorschoester deleted the fix-help-link-in-error-modal branch July 28, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog fix-before-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants