Skip to content

694 add unit tests to ai authorization domain section#22463

Merged
pls78 merged 4 commits intotrunkfrom
694-add-unit-tests-to-ai-authorization-domain-section
Aug 4, 2025
Merged

694 add unit tests to ai authorization domain section#22463
pls78 merged 4 commits intotrunkfrom
694-add-unit-tests-to-ai-authorization-domain-section

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Jul 28, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds tests for ai authorisation domain methods.

Relevant technical choices:

  • I decided to add all the tests for each method in one class since they are minimal.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

For Devs

  • Generate a coverage report (adapt the output directory ~/Desktop/wpseo to your OS):
./vendor/bin/phpunit --coverage-html ~/Desktop/wpseo --group ai-authorization
  • Open the wpseo folder on your desktop and open the index.html file
  • Navigate src -> ai-authorization -> domain
  • Check there is 100% coverage.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/694

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 28, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 28, 2025

Pull Request Test Coverage Report for Build 15a8d5aaccddb062c1e1cbd90473ec9059b25f12

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 52.3%

Files with Coverage Reduction New Missed Lines %
inc/class-my-yoast-api-request.php 1 97.06%
Totals Coverage Status
Change from base Build 517a519a6a21aacf7eb0c209f8d406d1cab39aad: -0.3%
Covered Lines: 30611
Relevant Lines: 59166

💛 - Coveralls

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per this thread, each test needs to be moved to its own class. You can see examples in tests\Unit\AI_HTTP_Request.

Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 merged commit 34413cd into trunk Aug 4, 2025
27 checks passed
@pls78 pls78 deleted the 694-add-unit-tests-to-ai-authorization-domain-section branch August 4, 2025 09:58
@pls78 pls78 added this to the 25.8 milestone Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants