Fix title in redirection page

[leonidasmi]

Context

Summary

This PR can be summarized in the following changelog entry:

• Fixes an unreleased bug where the title of the redirections page would be incorrectly showing double the word Redirects.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• With Premium disabled, go to Yoast->Redirects
• Confirm that the title in the tab is the expected one, Redirects - Yoast SEO < <SITE TITLE> - WordPress, which the same format with all Yoast pages:

• Regression: Go to the settings page and confirm that the title in the tab remains the same with what it was before this PR/RC.
  • Test with a couple of subsettings page, to make sure the title gets updated accordingly.
• Activate Premium and go to Yoast->Redirects
• Visit all 3 subpages there and confirm that the title in the tab gets the proper value:
  • Redirects - Yoast SEO < <SITE TITLE> - WordPress for the redirects subpage
  • Regex redirects < Redirects - Yoast SEO < <SITE TITLE> - WordPress for the regex redirects subpage
  • Redirect Method < Redirects - Yoast SEO < <SITE TITLE> - WordPress for the redirect method subpage

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• Like said above, regression test the title in the settings subpages.

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 4d76121a776689a34144ff7fd9ea71b2b52317c8

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 7 of 18 (38.89%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on 2455-257---trivial---page-name-in-the-browser-tab-is-not-proper-for-redirects-page at 30.628%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/redirects/components/route-layout.js	0	1	0.0%
packages/js/src/settings/components/route-layout.js	0	1	0.0%
packages/js/src/initializers/settings-store.js	0	3	0.0%
packages/js/src/shared-admin/store/document-title.js	6	12	50.0%

Totals
Change from base Build 24f6f53158f649005d90b2e54ecc87f7173e903a:	30.6%
Covered Lines:	4892
Relevant Lines:	14868

---

💛 - Coveralls

[vraja-pro]

CR and AC ✅