717 missing link params in redirects upsell link and learn more link

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• Fixes an unreleased bug where link param were missing from the redirects upsell link and learn more link.
• Refactors references slice according to the link params slice.

Relevant technical choices:

• I decided to refactor the reference slice for consistency.
• Removed a selector that was copied but is not related to the redirects page.
• Removed used values in the preferences.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Disable Yoast SEO premium if its active.
• Navigate to Yoast SEO -> Redirects
• Check the upsell link has link params, and so as the learn more.
• Change language to and RTL language (Hebrew/Arabic) and check the design has changed to RTL.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/717

[leonidasmi]

LGTM except one thing. Shouldnt the upsell have a data-action and a data-ctb-id attribute, like the other similar buttons eg. in the settings?

[github-actions]

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

[coveralls]

Pull Request Test Coverage Report for Build 86ad06a365568f893ef9460af96e1ac9c171fefe

Details

• 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-4.4%) to 52.648%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/redirects/initialize.js	0	1	0.0%
packages/js/src/redirects/store/preferences.js	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/redirects/store/preferences.js	1	0.0%

Totals
Change from base Build 4eddde3ba226c56e111c89147f2654998d2dbfd9:	-4.4%
Covered Lines:	31023
Relevant Lines:	59692

---

💛 - Coveralls

[vraja-pro]

Good catch @leonidasmi, I'll address that in a separate PR.

[leonidasmi]

CR + Acceptance is ✅