Skip to content

Use mentionResetInTooltip UsageCounter prop#22476

Merged
igorschoester merged 3 commits intorelease/25.7from
use-shouldreset-usagecounter-prop
Aug 5, 2025
Merged

Use mentionResetInTooltip UsageCounter prop#22476
igorschoester merged 3 commits intorelease/25.7from
use-shouldreset-usagecounter-prop

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented Aug 4, 2025

Context

  • The AI Generate usage counter tooltip needs to be adapted for the Free sparks case.

Summary

This PR can be summarized in the following changelog entry:

  • Adapts the AI Generate usage count tooltip in case of Free Sparks.
  • Bumps the @yoast/ai-frontend package dependency version to 0.18.0.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure you don't have Premium activated
  • Edit a post and click on Use AI
  • Hover the sparks count on the top right corner of the modal and confirm it shows a message like this:
    Screenshot 2025-08-05 at 10 24 36
  • Activate Premium and repeat the above steps
  • Confirm now the message has the following form:
    Screenshot 2025-08-05 at 10 30 44

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #724

@pls78 pls78 changed the title Use shouldReset UsageCounter prop Use mentionResetInTooltip UsageCounter prop Aug 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2025

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@pls78 pls78 force-pushed the use-shouldreset-usagecounter-prop branch from a7f045d to ded5675 Compare August 5, 2025 08:36
@pls78 pls78 added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 5, 2025
@pls78 pls78 changed the base branch from trunk to release/25.7 August 5, 2025 08:38
@pls78 pls78 added this to the 25.7 milestone Aug 5, 2025
@pls78 pls78 marked this pull request as ready for review August 5, 2025 08:44
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build f8d528c2569230e8a4f8c612ef9919991fa5c58a

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 52.85%

Files with Coverage Reduction New Missed Lines %
inc/class-my-yoast-api-request.php 1 97.06%
Totals Coverage Status
Change from base Build 1d18730644018690b58dd03758cc5eb8437561d2: 0.2%
Covered Lines: 31181
Relevant Lines: 59708

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit e53a0e6 into release/25.7 Aug 5, 2025
48 of 49 checks passed
@igorschoester igorschoester deleted the use-shouldreset-usagecounter-prop branch August 5, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants