Skip to content

Add unit tests for ai-generator#22478

Merged
vraja-pro merged 25 commits intotrunkfrom
615-ai-generator-unit-tests
Aug 18, 2025
Merged

Add unit tests for ai-generator#22478
vraja-pro merged 25 commits intotrunkfrom
615-ai-generator-unit-tests

Conversation

@SergeyBiryukov
Copy link
Copy Markdown
Member

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds unit tests covering the classes in src/ai-generator directory.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/615

@SergeyBiryukov SergeyBiryukov added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 4, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 5, 2025

Pull Request Test Coverage Report for Build e6c9f8296874d468cc942cb32bdb26daaa122e40

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • 92 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.9%) to 48.96%

Files with Coverage Reduction New Missed Lines %
src/presenters/admin/sidebar-presenter.php 43 0.0%
admin/class-premium-upsell-admin-block.php 49 0.0%
Totals Coverage Status
Change from base Build a03bb5eccab29068f7063a12ac7e3234c6e28b18: 0.9%
Covered Lines: 17064
Relevant Lines: 34853

💛 - Coveralls

@SergeyBiryukov SergeyBiryukov changed the title Add initial tests for ai-generator Add unit tests for ai-generator Aug 5, 2025
@SergeyBiryukov SergeyBiryukov marked this pull request as ready for review August 8, 2025 00:12
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for route-permission-trait.php

Comment thread tests/Unit/AI_Generator/Application/Suggestions_Provider/Get_Suggestions_Test.php Outdated
Comment thread tests/Unit/AI_Generator/Application/Suggestions_Provider/Get_Suggestions_Test.php Outdated
Comment thread tests/Unit/AI_Generator/Infrastructure/WordPress_URLs/Get_License_Url_Test.php Outdated
Comment thread tests/Unit/AI_Generator/Infrastructure/WordPress_URLs/Get_License_Url_Test.php Outdated
Comment thread tests/Unit/AI_Generator/User_Interface/Get_Usage_Route/Get_Usage_Test.php Outdated
Comment thread tests/Unit/AI_Generator/User_Interface/Get_Usage_Route/Get_Usage_Test.php Outdated
Comment thread tests/Unit/AI_Generator/User_Interface/Get_Usage_Route/Get_Usage_Test.php Outdated
@SergeyBiryukov
Copy link
Copy Markdown
Member Author

Missing tests for route-permission-trait.php

Thanks, added 👍

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@vraja-pro vraja-pro merged commit bb61263 into trunk Aug 18, 2025
26 checks passed
@vraja-pro vraja-pro deleted the 615-ai-generator-unit-tests branch August 18, 2025 11:48
@agnieszkaszuba agnieszkaszuba added this to the 25.9 milestone Aug 26, 2025
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants