Skip to content

exports doumentTitle reducer and action#22481

Merged
leonidasmi merged 2 commits intorelease/25.7from
2477-blocker-257---integration-page-is-broken
Aug 6, 2025
Merged

exports doumentTitle reducer and action#22481
leonidasmi merged 2 commits intorelease/25.7from
2477-blocker-257---integration-page-is-broken

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Aug 6, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where integration page would break.

Relevant technical choices:

  • Fixes also the export for the document title action.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Yoast SEO -> integrations
  • Check there is no console errors and the page is not broken.

For DEVS:

  • On the integration page, open the console and execute:
wp.data.dispatch( "yoast-seo/settings" )
  • Check the action setDocumentTitle is in the list.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/plugins-automated-testing/issues/2477

@vraja-pro vraja-pro added this to the 25.7 milestone Aug 6, 2025
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 6, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 6, 2025

Pull Request Test Coverage Report for Build 14277191b8463c46e3bdf4a14581391aad386e4b

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 52.655%

Totals Coverage Status
Change from base Build 95c836ad60857da5a3aba73a7d5d47a23febe9f5: 0.001%
Covered Lines: 31032
Relevant Lines: 59702

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance is ✅ (except from a minor improvement here that has been tested and seen from another dev here)

@leonidasmi leonidasmi merged commit 7f2a35c into release/25.7 Aug 6, 2025
19 checks passed
@leonidasmi leonidasmi deleted the 2477-blocker-257---integration-page-is-broken branch August 6, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants