Skip to content

Covers the 429 rate limi treached exception#22484

Merged
leonidasmi merged 2 commits intotrunkfrom
fix-upsell-instead-of-rate-limit-error
Aug 7, 2025
Merged

Covers the 429 rate limi treached exception#22484
leonidasmi merged 2 commits intotrunkfrom
fix-upsell-instead-of-rate-limit-error

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented Aug 7, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • WIP.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 7, 2025

Pull Request Test Coverage Report for Build 5d26df208c9765e990e553ee2e202933eaaaf84c

Details

  • 2 of 13 (15.38%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 52.906%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ai-generator/user-interface/get-suggestions-route.php 0 1 0.0%
packages/js/src/ai-generator/components/suggestion-error.js 0 2 0.0%
src/ai-generator/user-interface/get-usage-route.php 0 2 0.0%
packages/js/src/ai-generator/components/app.js 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/ai-generator/components/suggestion-error.js 1 7.41%
Totals Coverage Status
Change from base Build a205096259a815352792c0e1e9a23c86b6aa218d: -0.01%
Covered Lines: 31233
Relevant Lines: 59716

💛 - Coveralls

@leonidasmi leonidasmi merged commit 7200448 into trunk Aug 7, 2025
81 of 82 checks passed
@leonidasmi leonidasmi deleted the fix-upsell-instead-of-rate-limit-error branch August 7, 2025 14:45
@leonidasmi leonidasmi added this to the 25.7 milestone Aug 12, 2025
@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants