Skip to content

Components: remove Tabs#22492

Merged
vraja-pro merged 2 commits intotrunkfrom
237-upgrade-or-remove-react-tabs-to-a-version-that-supports-react-18
Aug 28, 2025
Merged

Components: remove Tabs#22492
vraja-pro merged 2 commits intotrunkfrom
237-upgrade-or-remove-react-tabs-to-a-version-that-supports-react-18

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester commented Aug 12, 2025

Context

Instead of upgrading react-select for React 19 compatibility.
Let's remove a very old unused component instead.

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/components 1.0.0 other] Removes the Tabs component.

Relevant technical choices:

  • There is also react-tabs hits in the stylesheet, that I think we could remove. But leaving it out of this PR as I'm not 100% on that

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Is it really never used?

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/237

Instead of upgrading `react-select` for React 19 compatibility.
Let's remove a very old unused component instead.
@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 12, 2025
@github-actions
Copy link
Copy Markdown

@igorschoester Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide
eslint-config-yoast packages/esling-config-yoast

Please consider using the other packages instead.

@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

…e-react-tabs-to-a-version-that-supports-react-18
@github-actions
Copy link
Copy Markdown

@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide
eslint-config-yoast packages/esling-config-yoast

Please consider using the other packages instead.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build d7e116bb397e01e3b336458b7f3769ac223e8859

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.32%

Totals Coverage Status
Change from base Build d89fc9c9206e044f86c4fccdc38b9a488b6aba60: 0.5%
Covered Lines: 31713
Relevant Lines: 59911

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅
I smoked test the metabox and sidebar tabs.

@vraja-pro vraja-pro added this to the 26.0 milestone Aug 27, 2025
@vraja-pro vraja-pro merged commit cc4927b into trunk Aug 28, 2025
25 checks passed
@vraja-pro vraja-pro deleted the 237-upgrade-or-remove-react-tabs-to-a-version-that-supports-react-18 branch August 28, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants