Skip to content

Free: Upgrade react-select to a version that supports React 19#22493

Merged
vraja-pro merged 2 commits intotrunkfrom
738-free-upgrade-react-select-to-a-version-that-supports-react-18
Sep 17, 2025
Merged

Free: Upgrade react-select to a version that supports React 19#22493
vraja-pro merged 2 commits intotrunkfrom
738-free-upgrade-react-select-to-a-version-that-supports-react-18

Conversation

@igorschoester
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester commented Aug 12, 2025

Context

Important

Branched out of #22466
Which removes react-select from the window API/webpack non-bundling (making this Free PR standalone from Premium and Local)
GitHub should auto-just the base branch to trunk when that is merged
Please first get that PR merged 😄

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/components 0.1.0 other] Upgrades react-select to v5 from v4.
  • Upgrades react-select in @yoast/components, which influences our Advanced and Schema Settings in our editor integrations.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Edit a post
  • Go to the Advanced Settings
  • Change things in the select and multi-select
  • Go to the Schema Settings
  • Change things
  • Save and verify the changes persisted

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • The react-select package, which seems to be only used in the Advanced and Schema Settings in our editor

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/738

@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 12, 2025
@github-actions
Copy link
Copy Markdown

@igorschoester Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide
eslint-config-yoast packages/esling-config-yoast

Please consider using the other packages instead.

Base automatically changed from 681-free-bump-wp-packages-to-minimum-supported-wp-version to trunk August 13, 2025 14:11
@github-actions
Copy link
Copy Markdown

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 17, 2025

Pull Request Test Coverage Report for Build 297d10614e31e12a540ccef7f714bf129941c501

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.205%

Totals Coverage Status
Change from base Build 05b3a038d4a3ad2af4fad16803f16807a7df7e02: 0.0%
Covered Lines: 31733
Relevant Lines: 59861

💛 - Coveralls

…ct-select-to-a-version-that-supports-react-18
@vraja-pro vraja-pro force-pushed the 738-free-upgrade-react-select-to-a-version-that-supports-react-18 branch from 2d909b1 to 76e953a Compare September 17, 2025 11:40
@github-actions
Copy link
Copy Markdown

@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide
eslint-config-yoast packages/esling-config-yoast

Please consider using the other packages instead.

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the 26.1 milestone Sep 17, 2025
@vraja-pro vraja-pro merged commit a014d2b into trunk Sep 17, 2025
20 checks passed
@vraja-pro vraja-pro deleted the 738-free-upgrade-react-select-to-a-version-that-supports-react-18 branch September 17, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants