Skip to content

Update the pull request template to no longer include the unused ui change label checkbox.#22500

Merged
leonidasmi merged 1 commit intotrunkfrom
742-update-pr-templates-to-not-include-a-ui-change-label-anymore
Aug 19, 2025
Merged

Update the pull request template to no longer include the unused ui change label checkbox.#22500
leonidasmi merged 1 commit intotrunkfrom
742-update-pr-templates-to-not-include-a-ui-change-label-anymore

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Aug 14, 2025

Context

  • We don't use the label so it is ready to remove it.

Summary

This PR can be summarized in the following changelog entry:

  • Removes a label from the PR template.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added this to the 25.9 milestone Aug 14, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 14, 2025
@thijsoo thijsoo removed this from the 25.9 milestone Aug 14, 2025
@leonidasmi leonidasmi added this to the 25.9 milestone Aug 19, 2025
@leonidasmi leonidasmi merged commit 8b72147 into trunk Aug 19, 2025
8 checks passed
@leonidasmi leonidasmi deleted the 742-update-pr-templates-to-not-include-a-ui-change-label-anymore branch August 19, 2025 06:43
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants