Skip to content

fix notification copy and BF badge#22504

Merged
leonidasmi merged 2 commits intofeature/bf-2025from
747-adapt-ads-for-new-pricing-and-packaging---update-copy-for-renewal-notification
Aug 22, 2025
Merged

fix notification copy and BF badge#22504
leonidasmi merged 2 commits intofeature/bf-2025from
747-adapt-ads-for-new-pricing-and-packaging---update-copy-for-renewal-notification

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Aug 19, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Changes the copy for updating plugin notification when there is no subscription and adds a badge for the Black Friday campaign.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Got to the plugins page.
  • Install Yoast SEO premium with an old version.
  • Check the copy of the update notification is:
Screenshot 2025-08-19 at 16 17 22
  • Go to /src/promotions/domain/black-friday-promotion.php and make sure the bf promotion is active by changing line 16 to: new Time_Interval( \gmmktime( 10, 00, 00, 11, 28, 2024 ), \gmmktime( 10, 00, 00, 12, 3, 2026 ) )

  • Refresh the plugin page and check the notification has the BF badge:

Screenshot 2025-08-19 at 16 21 58

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Adapt ads for new pricing and packaging - update copy for renewal notification

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 19, 2025
@vraja-pro vraja-pro added this to the feature/bf-2025 milestone Aug 19, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 19, 2025

Pull Request Test Coverage Report for Build a201caa000e569f1ef6efb1e4d263ff362c21ad5

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 747-adapt-ads-for-new-pricing-and-packaging---update-copy-for-renewal-notification at 48.985%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inc/class-addon-manager.php 0 5 0.0%
Totals Coverage Status
Change from base Build bff8b27b5ad182052331cc6c9ffb6daa9e42599a: 49.0%
Covered Lines: 17086
Relevant Lines: 34880

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR is ✅

Acceptance testing showed a minor improvement that can be done in the styling.

Comment thread css/src/admin-global.css
Co-authored-by: Leonidas Milosis <leonidas.milossis@gmail.com>
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance is ✅

@leonidasmi leonidasmi merged commit 0a2ef33 into feature/bf-2025 Aug 22, 2025
23 checks passed
@leonidasmi leonidasmi deleted the 747-adapt-ads-for-new-pricing-and-packaging---update-copy-for-renewal-notification branch August 22, 2025 07:03
@pls78 pls78 mentioned this pull request Aug 26, 2025
17 tasks
@pls78 pls78 modified the milestones: feature/bf-2025, 25.9 Aug 26, 2025
@enricobattocchi enricobattocchi mentioned this pull request Aug 27, 2025
17 tasks
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants