Skip to content

751 black friday ads 2025 plans page#22512

Merged
thijsoo merged 8 commits intofeature/bf-2025from
751-black-friday-ads-2025---plans-page
Aug 21, 2025
Merged

751 black friday ads 2025 plans page#22512
thijsoo merged 8 commits intofeature/bf-2025from
751-black-friday-ads-2025---plans-page

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Aug 20, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds the Black Friday badge for the plans cards in the plans page.

Relevant technical choices:

  • Moved the currentPromotions to the shared admin folder.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to /src/promotions/domain/black-friday-promotion.php and make sure the bf promotion is active by changing line 16 to:
    new Time_Interval( \gmmktime( 10, 00, 00, 11, 28, 2024 ), \gmmktime( 10, 00, 00, 12, 3, 2026 ) )

  • Go to Yoast SEO -> Plans

  • Check the cards now have a badge for the Black Friday:

Screenshot 2025-08-20 at 16 05 36
  • Enable Yoast SEO Premium without licence, check the card for premium has the badge "Plan not activated" and not the Black Friday.
  • Enabled the licence and check the card has "Plan activated" and not the Black Friday badge.
  • Enable Woo SEO and check now the woo plan card has "Plan not activated" and the premium has the Black Friday badge.
  • Restore the promotion dates, Go to /src/promotions/domain/black-friday-promotion.php and make sure the bf promotion is active by changing line 16 to:
    new Time_Interval( \gmmktime( 10, 00, 00, 11, 28, 2024 ), \gmmktime( 10, 00, 00, 12, 3, 2024 ) )
  • Check the plans card

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/751

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 20, 2025
@vraja-pro vraja-pro force-pushed the 751-black-friday-ads-2025---plans-page branch from 9d478e4 to 4bf2333 Compare August 20, 2025 13:22
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 21, 2025

Pull Request Test Coverage Report for Build d4071aa27b35236fa928ab037df8cc641fa05c85

Details

  • 9 of 14 (64.29%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 751-black-friday-ads-2025---plans-page at 41.466%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/plans/components/cards/premium-card.js 0 1 0.0%
packages/js/src/plans/components/cards/woo-card.js 0 1 0.0%
packages/js/src/plans/store/index.js 0 3 0.0%
Totals Coverage Status
Change from base Build bff8b27b5ad182052331cc6c9ffb6daa9e42599a: 41.5%
Covered Lines: 21967
Relevant Lines: 49802

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thijsoo thijsoo added this to the feature/bf-2025 milestone Aug 21, 2025
@thijsoo thijsoo merged commit 25c8999 into feature/bf-2025 Aug 21, 2025
39 of 40 checks passed
@thijsoo thijsoo deleted the 751-black-friday-ads-2025---plans-page branch August 21, 2025 12:53
@pls78 pls78 mentioned this pull request Aug 26, 2025
17 tasks
@pls78 pls78 modified the milestones: feature/bf-2025, 25.9 Aug 26, 2025
@enricobattocchi enricobattocchi mentioned this pull request Aug 27, 2025
17 tasks
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants