Skip to content

Remove files.#22527

Merged
vraja-pro merged 1 commit intotrunkfrom
640-cleanup-licensesphp-view-files
Aug 27, 2025
Merged

Remove files.#22527
vraja-pro merged 1 commit intotrunkfrom
640-cleanup-licensesphp-view-files

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Aug 26, 2025

Context

  • Removes two now unused files.

Summary

This PR can be summarized in the following changelog entry:

  • Removes files from the old plans page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the plugin and also in multisite to make sure that there are no errors of missing files.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 26, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7741d9af85e2922f696b4492169b062e110ff9c9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 48.926%

Totals Coverage Status
Change from base Build 5c58a5f9c8a3e4ddeb7ce7d95f410b99ef1dac19: 0.02%
Covered Lines: 17066
Relevant Lines: 34881

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the 26.0 milestone Aug 27, 2025
@vraja-pro vraja-pro merged commit d89fc9c into trunk Aug 27, 2025
28 checks passed
@vraja-pro vraja-pro deleted the 640-cleanup-licensesphp-view-files branch August 27, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants