Skip to content

Remove Slack webhook from verify-zip-size task#22539

Merged
enricobattocchi merged 1 commit intorelease/25.9from
remove-zipsize-slackhook
Aug 28, 2025
Merged

Remove Slack webhook from verify-zip-size task#22539
enricobattocchi merged 1 commit intorelease/25.9from
remove-zipsize-slackhook

Conversation

@enricobattocchi
Copy link
Copy Markdown
Member

@enricobattocchi enricobattocchi commented Aug 28, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes the Slack webhook from verify-zip-size task to avoid a failure when creating a RC bigger than 5 MB.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • NA, only related to RC creation

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 28, 2025
@enricobattocchi enricobattocchi added this to the 25.9 milestone Aug 28, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 10bb0c639fc6d8fe682e98b9cdd0d4370f0dc516

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.206%

Totals Coverage Status
Change from base Build e04d39fefca75afa2b41d908e750766b9fb6f73c: 0.0%
Covered Lines: 31641
Relevant Lines: 59937

💛 - Coveralls

@enricobattocchi enricobattocchi merged commit 0679a5b into release/25.9 Aug 28, 2025
22 checks passed
@enricobattocchi enricobattocchi deleted the remove-zipsize-slackhook branch August 28, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants