757 clean up the outdated upsell components

[vraja-pro]

Context

Summary

This PR can be summarized in the following changelog entry:

• Clean up Black Friday check list ad and upsell outdated and unused modals.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Reset the user meta _yoast_alerts_dismissed to restore the ad that was dismiss.
• Check you see the Webinar ad in the sidebar ( if you see trust pilot ad, dismiss it first).
• Do not dismiss the webinar ad.
• Activate the Black Friday promotion in the file.
• Check you see the Black Friday the the block editor sidebar.
• Dismiss the BF ad.
• Refresh and check you see the Webinar ad.
• Reset the user meta _yoast_alerts_dismissed to restore the ad that was dismiss.
• Repeat the tests for elementor.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/757

[coveralls]

Pull Request Test Coverage Report for Build 0b9b4b5c2de49847848164cd3cd6e75656cfad68

Details

• 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
• 3 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.06%) to 53.204%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/components/fills/MetaboxFill.js	0	1	0.0%
packages/js/src/helpers/shouldShowWebinarPromotionNotification.js	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/components/fills/MetaboxFill.js	1	0.0%
packages/js/src/initializers/settings-header.js	1	0.0%
packages/js/src/general/app.js	1	0.0%

Totals
Change from base Build 336cca8fcb7095eb0165e49d02969b7a621ac323:	0.06%
Covered Lines:	31672
Relevant Lines:	59756

---

💛 - Coveralls

[github-actions]

A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch.

[pls78]

CR && Acc: ✅