Skip to content

Automatically open the Advanced Settings section when visiting llms.txt feature#22542

Merged
thijsoo merged 1 commit intotrunkfrom
open-advanced-menu-when-on-llms-feature
Aug 28, 2025
Merged

Automatically open the Advanced Settings section when visiting llms.txt feature#22542
thijsoo merged 1 commit intotrunkfrom
open-advanced-menu-when-on-llms-feature

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented Aug 28, 2025

Context

  • The settings dedicated to the llms.txt file are in a sub-section of the Settings' Advanced section, which is collapsed by default. This means that if the user is directed to the llms.txt sub-section they cannot see in which section they are (provided they didn't previously open the Advanced section).

Summary

This PR can be summarized in the following changelog entry:

  • Opens the Advanced Settings' section when clicking the Customize llms.txt file button.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Visit Yoast SEO -> Settings
    • Verify the Advanced section is collapsed
    • In Site features enablethellms.txt` feature
    • Click on Customize llms.txt file
    • Verify the Advanced section is now open

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #271

@pls78 pls78 added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Aug 28, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build cd845b29438f7cf97f83ffde4181091163389283

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 53.317%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/settings/app.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/settings/app.js 1 0.0%
Totals Coverage Status
Change from base Build e9cd8ddac39df5b8fdc1e723737eac1a95868140: -0.001%
Covered Lines: 31717
Relevant Lines: 59922

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo added this to the 26.0 milestone Aug 28, 2025
@thijsoo thijsoo merged commit f9e7610 into trunk Aug 28, 2025
21 checks passed
@thijsoo thijsoo deleted the open-advanced-menu-when-on-llms-feature branch August 28, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants