Skip to content

delete old deprecated files.#22543

Merged
vraja-pro merged 2 commits intotrunkfrom
22538-remove-deprecated-classes-up-to-235-included
Aug 29, 2025
Merged

delete old deprecated files.#22543
vraja-pro merged 2 commits intotrunkfrom
22538-remove-deprecated-classes-up-to-235-included

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Aug 28, 2025

Context

  • We want to remove some unused classes.

Summary

This PR can be summarized in the following changelog entry:

  • Removes deprecated classes up until 23.5.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke test the plugin to see if there are any issues.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 28, 2025
@thijsoo thijsoo linked an issue Aug 28, 2025 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 28, 2025

Pull Request Test Coverage Report for Build 4e30000bb28eb39d3bedb0b0cc4ef3c16e3ce771

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 52.852%

Totals Coverage Status
Change from base Build e9cd8ddac39df5b8fdc1e723737eac1a95868140: -0.5%
Covered Lines: 31211
Relevant Lines: 59393

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the 26.0 milestone Aug 29, 2025
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅
Updated the thresholds.

@vraja-pro vraja-pro merged commit cee786d into trunk Aug 29, 2025
25 checks passed
@vraja-pro vraja-pro deleted the 22538-remove-deprecated-classes-up-to-235-included branch August 29, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated classes up to 23.5 (included)

3 participants