Skip to content

Correct invalid @covers tags in llms.txt and Links_Table_Runner_Test unit tests and the deprecated assertion in Wistia_Embed_Permission_Repository_Test#22544

Merged
vraja-pro merged 4 commits intotrunkfrom
761-llms-txt-covers-tags
Aug 29, 2025
Merged

Correct invalid @covers tags in llms.txt and Links_Table_Runner_Test unit tests and the deprecated assertion in Wistia_Embed_Permission_Repository_Test#22544
vraja-pro merged 4 commits intotrunkfrom
761-llms-txt-covers-tags

Conversation

@SergeyBiryukov
Copy link
Copy Markdown
Member

@SergeyBiryukov SergeyBiryukov commented Aug 28, 2025

Context

  • This resolves warnings when running the test suite:
2) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Application\File\Llms_Txt_Cron_Scheduler\Schedule_Quick_Population_Test::test_schedule_quick_llms_txt_population with data set "feature enabled and not scheduled" (true, false)
"@covers ::schedule_quick_llms_txt_population" is invalid

3) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Application\File\Llms_Txt_Cron_Scheduler\Schedule_Quick_Population_Test::test_schedule_quick_llms_txt_population with data set "feature disabled" (false, false)
"@covers ::schedule_quick_llms_txt_population" is invalid

4) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Application\File\Llms_Txt_Cron_Scheduler\Schedule_Quick_Population_Test::test_schedule_quick_llms_txt_population with data set "feature enabled and scheduled" (true, true)
"@covers ::schedule_quick_llms_txt_population" is invalid

5) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Infrastructure\Content_Types_Collector\Get_Content_Types_Lists_Test::test_get_content_types_lists with data set "1 indexable post type with 1 post" (array(stdClass Object (...)), 1, array(true), array(array('post', 5, 'publish', 'modified', 'DESC', false, array(array('12 months ago')))), 1, array(stdClass Object (...)), false, 1, 1)
"@covers Yoast\WP\SEO\Llms_Txt\Infrastructure\Markdown_Services\Content_Types_Collector::get_posts" is invalid

6) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Infrastructure\Content_Types_Collector\Get_Content_Types_Lists_Test::test_get_content_types_lists with data set "2 post types with 3 posts each and one non-indexable post type" (array(stdClass Object (...), stdClass Object (...), stdClass Object (...)), 3, array(true, true, false), array(array('post', 5, 'publish', 'modified', 'DESC', false, array(array('12 months ago'))), array('page', 5, 'publish', 'modified', 'DESC', false)), 2, array(stdClass Object (...), stdClass Object (...), stdClass Object (...)), true, 2, 2)
"@covers Yoast\WP\SEO\Llms_Txt\Infrastructure\Markdown_Services\Content_Types_Collector::get_posts" is invalid

7) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Infrastructure\Content_Types_Collector\Get_Content_Types_Lists_Test::test_get_content_types_lists with data set "1 non-indexable post type" (array(stdClass Object (...)), 1, array(false), array(array('irrelevant')), 0, array(), false, 0, 0)
"@covers Yoast\WP\SEO\Llms_Txt\Infrastructure\Markdown_Services\Content_Types_Collector::get_posts" is invalid

8) Yoast\WP\SEO\Tests\Unit\Llms_Txt\Infrastructure\Content_Types_Collector\Get_Content_Types_Lists_Test::test_get_content_types_lists with data set "no post types" (array(), 0, array('irrelevant'), array(array('irrelevant')), 0, array(), false, 0, 0)
"@covers Yoast\WP\SEO\Llms_Txt\Infrastructure\Markdown_Services\Content_Types_Collector::get_posts" is invalid

Summary

This PR can be summarized in the following changelog entry:

  • Correct invalid @covers tags in unit tests for llms.txt.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

See https://github.com/Yoast/reserved-tasks/issues/761

@SergeyBiryukov SergeyBiryukov added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 28, 2025
@SergeyBiryukov SergeyBiryukov changed the title Correct invalid @covers tags in llms.txt Correct invalid @covers tags in llms.txt unit tests Aug 28, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 0f7472fc03d835e2042f15d3cfabbacc626e28c7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 761-llms-txt-covers-tags at 49.428%

Totals Coverage Status
Change from base Build f9e761075590c350af58ccd8cee8b6ddeb31aa14: 49.4%
Covered Lines: 17253
Relevant Lines: 34905

💛 - Coveralls

@vraja-pro vraja-pro self-assigned this Aug 29, 2025
@vraja-pro
Copy link
Copy Markdown
Contributor

I fixed in this PR the rest of the warnings.

@vraja-pro vraja-pro changed the title Correct invalid @covers tags in llms.txt unit tests Correct invalid @covers tags in llms.txt and Links_Table_Runner_Test unit tests and the deprecated assertion in Wistia_Embed_Permission_Repository_Test Aug 29, 2025
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@vraja-pro vraja-pro added this to the 26.0 milestone Aug 29, 2025
@vraja-pro vraja-pro merged commit 746fea3 into trunk Aug 29, 2025
36 of 39 checks passed
@vraja-pro vraja-pro deleted the 761-llms-txt-covers-tags branch August 29, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants