Skip to content

Removes duplicate enqueue of language script since it's a dependency of the analysis package#22554

Merged
thijsoo merged 1 commit intotrunkfrom
663-remove-enququeing-of-language-script-in-admin-pages
Sep 22, 2025
Merged

Removes duplicate enqueue of language script since it's a dependency of the analysis package#22554
thijsoo merged 1 commit intotrunkfrom
663-remove-enququeing-of-language-script-in-admin-pages

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Sep 8, 2025

It is a dependency of the analysis package

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes duplicate enqueue of language script since it's a dependency of the analysis package.

Relevant technical choices:

  • The language script is a dependency of the analysis-package so no need to enqueue it separately. This was done in Add guard to the loading scripts for features that are disabled in free as an attempt to prevent the enqueueing of the language script, however it is not possible since it's a dependency of the analysis-package so it is already being added.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure site language is English.
  • Edit a post in classic/block-editor/elementor and edit a term.
  • Inspect the page source and search for a script with the name "yoast-seo-en-language-js".
  • Check it is there.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Remove enququeing of language script in admin pages

It is a dependency of the analysis package
@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 8, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 45ef9002c78a186556e42ed34601397d94e61ade

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 52.801%

Totals Coverage Status
Change from base Build 7e7d0528ec39f53b8b8009fb5bdc1d6db3f32c7b: 0.002%
Covered Lines: 31216
Relevant Lines: 59233

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo added this to the 26.1 milestone Sep 22, 2025
@thijsoo thijsoo merged commit c552e3a into trunk Sep 22, 2025
27 checks passed
@thijsoo thijsoo deleted the 663-remove-enququeing-of-language-script-in-admin-pages branch September 22, 2025 10:22
@thijsoo thijsoo mentioned this pull request Sep 22, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants