Skip to content

Fixes notification position on rtl#22560

Merged
leonidasmi merged 1 commit intotrunkfrom
772-fix-llm-opt-in-for-rtl-in-general-page
Sep 11, 2025
Merged

Fixes notification position on rtl#22560
leonidasmi merged 1 commit intotrunkfrom
772-fix-llm-opt-in-for-rtl-in-general-page

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Sep 10, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the llm.txt opt-in would hide behind the WordPress sidebar when on RTL language.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Reset user meta wpseo_seen_llm_txt_opt_in_notification or have a fresh environment.
  • Change site language to an RTL one like Hebrew or Arabic.
  • Make sure the llm feature is turned off.
  • Go to the General page and make sure the opt-in is not behind the black WP sidebar.
  • Reset user meta wpseo_seen_llm_txt_opt_in_notification or have a fresh environment or login as a new user.
  • Change the site language back to English.
  • Go to the general page and check the llm.txt opt-in is not behind the black WP sidebar.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/772

@vraja-pro vraja-pro added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Sep 10, 2025
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance is ✅

@leonidasmi leonidasmi added this to the 26.1 milestone Sep 11, 2025
@leonidasmi leonidasmi merged commit e91ff95 into trunk Sep 11, 2025
21 of 22 checks passed
@leonidasmi leonidasmi deleted the 772-fix-llm-opt-in-for-rtl-in-general-page branch September 11, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants