773 improve editor upsells

[vraja-pro]

Context

• Improved editor upsells.

Summary

This PR can be summarized in the following changelog entry:

• Renews Premium SEO analysis ads design and links on the editor.

Relevant technical choices:

• Removes 5 upsells in total and replaces them with the new ad.
• Adds upsell links for elementor editor.
• Adds Woo SEO upsell links when woocommerce is detected.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Edit a post and click on the SEO analysis tab
• Check you see the new design for Premium SEO Analysis like in the following design:

* Check the upsell button has attribute ctb-id : f6a84663-465f-4cb5-8ba5-f7a6d72224b2 * Check the button has a different link for the ad in metabox, sidebar and elementor, with link params: * Metabox: https://yoa.st/premium-seo-analysis-metabox * Block editor sidebar: https://yoa.st/premium-seo-analysis-sidebar * Elementor sidebar: https://yoa.st/premium-seo-analysis-elementor

• Activate WooCommerce and Check the ads now have a different design and different links:
• Check the button has a different link for the ad in metabox, sidebar and elementor, with link params:
  • Metabox: https://yoa.st/seo-analysis-metabox-woocommerce
  • Block editor sidebar: https://yoa.st/seo-analysis-sidebar-woocommerce
  • Elementor sidebar: https://yoa.st/seo-analysis-woocommerce-elementor
• Check the upsell button has attribute ctb-id : f6a84663-465f-4cb5-8ba5-f7a6d72224b2

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes Improve editor upsells

[coveralls]

Pull Request Test Coverage Report for Build f43c8175b59d725895b18a68869b616cbf3a4dd3

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 30 (0.0%) changed or added relevant lines in 3 files are covered.
• 165 unchanged lines in 9 files lost coverage.
• Overall coverage increased (+0.02%) to 53.236%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
admin/class-expose-shortlinks.php	0	4	0.0%
packages/js/src/components/contentAnalysis/WooSeoAnalysisUpsellAd.js	0	11	0.0%
packages/js/src/components/contentAnalysis/PremiumSeoAnalysisUpsellAd.js	0	15	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/settings/helpers/validation.js	2	19.15%
packages/js/src/settings/helpers/search.js	6	15.0%
admin/tracking/class-tracking-settings-data.php	6	0.0%
packages/js/src/introductions/initialize.js	10	0.0%
src/integrations/front-end-integration.php	15	84.06%
inc/options/class-wpseo-option-wpseo.php	21	86.61%
packages/js/src/settings/routes/llms-txt.js	26	0.0%
wp-seo-main.php	35	0.0%
inc/options/class-wpseo-option.php	44	36.65%

Totals
Change from base Build 5a27d028caa37d7ee86021a40e9b33a0cedf1336:	0.02%
Covered Lines:	31734
Relevant Lines:	59852

---

💛 - Coveralls

[thijsoo]

One small suggestion

[thijsoo]

CR + ACC 👍