Skip to content

Adapt display to the Wincher API updates#22578

Merged
enricobattocchi merged 1 commit intorelease/26.0from
fix/wincher-api-update
Sep 19, 2025
Merged

Adapt display to the Wincher API updates#22578
enricobattocchi merged 1 commit intorelease/26.0from
fix/wincher-api-update

Conversation

@enricobattocchi
Copy link
Copy Markdown
Member

@enricobattocchi enricobattocchi commented Sep 18, 2025

Context

  • Slack thread
    TL;DR: Since late Thu, Sep 18 Wincher has updated their API to get only the top 30 results. We need to adapt our plugin to support it.

Summary

This PR can be summarized in the following changelog entry:

  • Ensures compatibility with the recent Wincher API changes.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • edit a post
  • add a keyphrase
  • click on "Track SEO performance" in the metabox
  • connect to Wincher if you are not yet
  • check that in the chart 31 is the lowest value
  • check that if you have a very low ranking keyphrase you get > 30 as Position in the table and in the chart the line or the point is at the bottom

Examples:

Good (chart shows 31 at the bottom)
Screenshot 2025-09-19 at 10-27-07 Modifica articolo “Duplicate Post joins Yoast” ‹ blog Lopo it — WordPress

Good (chart shows 31 at the bottom, the position is >30)
Screenshot 2025-09-19 at 10-26-53 Modifica articolo “ChatGPT” ‹ blog Lopo it — WordPress

Bad (chart shows 101 at the bottom, the position is 31)
Screenshot 2025-09-19 at 10-19-05 Modifica articolo “ChatGPT” ‹ blog Lopo it — WordPress

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added this to the 26.0 milestone Sep 18, 2025
@enricobattocchi enricobattocchi added changelog: other Needs to be included in the 'Other' category in the changelog fix-before-release labels Sep 18, 2025
@enricobattocchi enricobattocchi self-assigned this Sep 18, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build d03a3a651b4d8be19260bd0f66f4c184a55ddc70

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.213%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/components/WincherTableRow.js 2 3 66.67%
Totals Coverage Status
Change from base Build 0301b748819cd04ec342573443cb0c0e7d182954: 0.0%
Covered Lines: 31733
Relevant Lines: 59853

💛 - Coveralls

@enricobattocchi enricobattocchi marked this pull request as ready for review September 19, 2025 08:01
@enricobattocchi enricobattocchi merged commit 08da18e into release/26.0 Sep 19, 2025
31 checks passed
@enricobattocchi enricobattocchi deleted the fix/wincher-api-update branch September 19, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: other Needs to be included in the 'Other' category in the changelog fix-before-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants