Skip to content

Update site-features and remove old unused images.#22581

Merged
vraja-pro merged 1 commit intotrunkfrom
774-update-settings-site-features
Sep 19, 2025
Merged

Update site-features and remove old unused images.#22581
vraja-pro merged 1 commit intotrunkfrom
774-update-settings-site-features

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Sep 18, 2025

Context

  • we want to replace images with icons and move some things up to a AI part.

Summary

This PR can be summarized in the following changelog entry:

  • Updates the Site features page to include icons instead of images.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure the page looks like the design from the issue. Take note that the AI tools section is not in the design.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • I have removed a couple of images which should only have been used on the settings page. But do a smoke test of the back-end to make sure there are no images missing.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: other Needs to be included in the 'Other' category in the changelog label Sep 18, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7e14c36be622db192bbfebffad8450c037492524

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 53.204%

Totals Coverage Status
Change from base Build fdd462ee8f31ded73c41e9143506f2987e48130c: 0.5%
Covered Lines: 31733
Relevant Lines: 59862

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & AC ✅

@vraja-pro vraja-pro added this to the 26.1 milestone Sep 19, 2025
@vraja-pro vraja-pro merged commit 4bc51ba into trunk Sep 19, 2025
21 checks passed
@vraja-pro vraja-pro deleted the 774-update-settings-site-features branch September 19, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: other Needs to be included in the 'Other' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants