Skip to content

Fix _load_textdomain_just_in_time being called incorrectly#22588

Merged
enricobattocchi merged 3 commits intorelease/26.0from
fix/incorrect_load_textdomain_just_in_time
Sep 22, 2025
Merged

Fix _load_textdomain_just_in_time being called incorrectly#22588
enricobattocchi merged 3 commits intorelease/26.0from
fix/incorrect_load_textdomain_just_in_time

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Sep 22, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where _load_textdomain_just_in_time was called incorrectly on the post pages.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Have a non-english site
  • Go to either the post overview page or the edit post page
  • Confirm that you dont get the following notice in your debug.log (or via Query Monitor):
PHP Notice:  Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>wordpress-seo</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added this to the 26.0 milestone Sep 22, 2025
@enricobattocchi enricobattocchi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 22, 2025
@leonidasmi leonidasmi marked this pull request as ready for review September 22, 2025 12:46
@enricobattocchi enricobattocchi merged commit 27d184d into release/26.0 Sep 22, 2025
28 checks passed
@enricobattocchi enricobattocchi deleted the fix/incorrect_load_textdomain_just_in_time branch September 22, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants