Skip to content

Add css needed by frontend to render the new badge#22591

Merged
thijsoo merged 6 commits intorelease/26.1from
fix-badge-in-frontend
Sep 24, 2025
Merged

Add css needed by frontend to render the new badge#22591
thijsoo merged 6 commits intorelease/26.1from
fix-badge-in-frontend

Conversation

@pls78
Copy link
Copy Markdown
Member

@pls78 pls78 commented Sep 22, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where the New badge in the admin bar Yoast Upgrade button would be rendered incorrectly.
  • Adds a margin between the Learn more string and the arrow in the Plans page cards' Learn more button.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Activate Premium
  • Go to your blog frontend and check the the New badge in the admin bar Yoast Upgrade button conforms to the Figma design
  • Go to Yoast SEO -> Plans
  • Verify the Learn morestring and the arrow in the Learn more buttons are spaced like in the Figma design

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22589

@pls78 pls78 added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 22, 2025
@pls78 pls78 marked this pull request as ready for review September 22, 2025 13:56
@thijsoo thijsoo changed the base branch from trunk to release/26.1 September 24, 2025 07:18
Comment thread css/src/adminbar.css Outdated
}

#wpseo-new-badge-upgrade {
display: inline-flex;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this with tailwind styles.

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its worth it to change as many styles to the tailwind ones to be consistent.

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo added this to the 26.1 milestone Sep 24, 2025
@thijsoo thijsoo merged commit d905544 into release/26.1 Sep 24, 2025
30 of 33 checks passed
@thijsoo thijsoo deleted the fix-badge-in-frontend branch September 24, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AI+ - Fix New badge on the Upgrade button in the frontend admin bar

2 participants