Skip to content

Revert "implement new ai frontend gradient button variant"#22593

Merged
leonidasmi merged 1 commit intotrunkfrom
revert-22579-727-improve-re-usability-of-ai-buttons
Sep 23, 2025
Merged

Revert "implement new ai frontend gradient button variant"#22593
leonidasmi merged 1 commit intotrunkfrom
revert-22579-727-improve-re-usability-of-ai-buttons

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Sep 23, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Reverts a not needed commit that broke the sidebar menu in the settings page.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Delete the introductions user meta (yoast_wpseo_introductions) to trigger the insights modal again.
  • Go to one of yoast admin pages like the settings page.
  • Smoke test the insights introduction modal gradient button.
  • Check the the focus is on the gradient button.
  • Also confirm that the settings page has its sidebar menu back

@thijsoo thijsoo added this to the 26.1 milestone Sep 23, 2025
@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 23, 2025
@thijsoo thijsoo assigned thijsoo and unassigned thijsoo Sep 23, 2025
@leonidasmi leonidasmi self-assigned this Sep 23, 2025
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + Acceptance is ✅

@leonidasmi leonidasmi merged commit b2444c1 into trunk Sep 23, 2025
41 of 43 checks passed
@leonidasmi leonidasmi deleted the revert-22579-727-improve-re-usability-of-ai-buttons branch September 23, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants