Add pronouns to user profile and schema#22598
Merged
Conversation
…press-seo into add-pronouns-to-user-profile-and-schema
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
pronounswas added toPersonschema's pending state. This pull implements it for Yoast SEO.Summary
This PR can be summarized in the following changelog entry:
Pronounsfield to the user profile and includes these pronouns in the Schema.org output. Props to jdevalk.Relevant technical choices:
Textvalue, as Schema.org states:admin/views/user-profile.php(which seems unused?) and in a new filesrc/user-meta/framework/custom-meta/author-pronouns.php.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Users->ProfileYoast SEO settingssection, add your pronouns in thePronouns to usefieldPersonSchema piece has apronounsproperty with the value specified in your profileUsers->ProfilePronouns to usefield blankPersonSchema piece doesn't have thepronounsproperty anymoreRelevant test scenarios
Test instructions for QA when the code is in the RC
UI changes
Documentation
Quality assurance
Fixes #22595