Skip to content

Open links for the AI generate feature in new tabs#22620

Merged
thijsoo merged 2 commits intofeature/adoption-1from
fix/open-ai-generate-links-in-new-tab
Oct 6, 2025
Merged

Open links for the AI generate feature in new tabs#22620
thijsoo merged 2 commits intofeature/adoption-1from
fix/open-ai-generate-links-in-new-tab

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

Context

Summary

This PR can be summarized in the following changelog entry:

  • Opens the links in the AI generate notifications in new tabs.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog required-for-rc An issue that needs to be addressed before the next RC is created labels Oct 6, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 6, 2025

Pull Request Test Coverage Report for Build 037b7d44bffc210505f9441e3749258c38c6c99b

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/alerts/application/default-seo-data/default-seo-data-alert.php 0 1 0.0%
Totals Coverage Status
Change from base Build 992d0ac75a4f396ae87ec97412dd22b390fcabd3: 0.0%
Covered Lines: 31267
Relevant Lines: 59518

💛 - Coveralls

@leonidasmi leonidasmi added this to the feature/adoption-1 milestone Oct 6, 2025
@thijsoo thijsoo self-assigned this Oct 6, 2025
Comment thread src/alerts/application/default-seo-data/default-seo-data-alert.php Outdated
….php

Co-authored-by: Thijs van der Heijden <thijsoo@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit cd3adc2 into feature/adoption-1 Oct 6, 2025
25 checks passed
@thijsoo thijsoo deleted the fix/open-ai-generate-links-in-new-tab branch October 6, 2025 10:55
@leonidasmi leonidasmi mentioned this pull request Oct 7, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog required-for-rc An issue that needs to be addressed before the next RC is created

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants