Skip to content

Fix/copy for default seo data alerts#22624

Merged
thijsoo merged 1 commit intofeature/adoption-1from
fix/copy-for-default-seo-data-alerts
Oct 7, 2025
Merged

Fix/copy for default seo data alerts#22624
thijsoo merged 1 commit intofeature/adoption-1from
fix/copy-for-default-seo-data-alerts

Conversation

@leonidasmi
Copy link
Copy Markdown
Contributor

@leonidasmi leonidasmi commented Oct 7, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Finalizes the copy of the new alerts for default SEO titles and meta descriptions.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

image
image
image

and if you activate Premium:
image


image
image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 7, 2025
@leonidasmi leonidasmi changed the base branch from trunk to feature/adoption-1 October 7, 2025 08:21
@leonidasmi leonidasmi added this to the feature/adoption-1 milestone Oct 7, 2025
@leonidasmi leonidasmi marked this pull request as ready for review October 7, 2025 08:31
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 085bb9905a29a1c9f4a86e2241bf4c61c9424712

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 119 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.007%) to 52.671%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/alerts/application/default-seo-data/default-seo-data-alert.php 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/integrations/admin/redirections-tools-page.php 8 0.0%
admin/class-expose-shortlinks.php 11 0.0%
src/integrations/admin/helpscout-beacon.php 100 0.0%
Totals Coverage Status
Change from base Build cd3adc2bc619ad5b187b27e7434d055b34059b05: -0.007%
Covered Lines: 31269
Relevant Lines: 59532

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thijsoo thijsoo merged commit 55d75e2 into feature/adoption-1 Oct 7, 2025
30 of 31 checks passed
@thijsoo thijsoo deleted the fix/copy-for-default-seo-data-alerts branch October 7, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants