Improve bottom and sidebar upsells

[enricobattocchi]

Context

Summary

This PR can be summarized in the following changelog entry:

• Improves the bottom and the sidebar upsell in the Yoast admin pages.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• We have already a UX acceptance from @uxkai so what is needed is basically:
  • check the 2 cases (with and without WooCommerce installed)
  • check with the BF promotion on (change the date in /src/promotions/domain/black-friday-promotion.php#L16)

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/ux/issues/318
Fixes https://github.com/Yoast/ux/issues/319

[coveralls]

Pull Request Test Coverage Report for Build 765d2f0b500944483416190d3dfcaaf7118550d6

Details

• 0 of 33 (0.0%) changed or added relevant lines in 3 files are covered.
• 2 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.4%) to 53.315%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/js/src/shared-admin/components/premium-upsell-list.js	0	4	0.0%
src/presenters/admin/sidebar-presenter.php	0	10	0.0%
admin/class-premium-upsell-admin-block.php	0	19	0.0%

Files with Coverage Reduction	New Missed Lines	%
packages/js/src/shared-admin/components/premium-upsell-list.js	1	6.06%
admin/class-premium-upsell-admin-block.php	1	0.0%

Totals
Change from base Build 99c83c550452bfb79a03d6ccb8e025a1f81c0906:	0.4%
Covered Lines:	31965
Relevant Lines:	60197

---

💛 - Coveralls

[Copilot]

Pull Request Overview

This PR improves the upsell components in the Yoast admin pages by enhancing their visual design and accessibility. The changes focus on making the premium and academy upsells more visually appealing and accessible to users.

• Updated styling and layout for better visual hierarchy and spacing
• Enhanced accessibility with screen reader text for external links
• Improved visual indicators with icons and badges for better user experience

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/presenters/admin/sidebar-presenter.php	Added external link icon and accessibility text to academy link
packages/js/src/shared-admin/components/premium-upsell-list.js	Enhanced layout with badges, improved spacing, and added accessibility features
packages/js/src/shared-admin/components/premium-upsell-card.js	Minor styling adjustments for list padding and font weight
packages/js/src/shared-admin/components/academy-upsell-card.js	Added external link icon and accessibility text
css/src/yst_plugin_tools.css	Updated styles for custom check icons, badges, and improved spacing
admin/class-premium-upsell-admin-block.php	Replaced bullet points with check icons and restructured "now includes" section

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[pls78]

CR && Acc: ✅