Skip to content

Revert "Check addons subscription only if any addon is activated"#22655

Merged
thijsoo merged 1 commit intorelease/26.2from
revert-22634-check-addons-subscription-only-if-any-addon-is-activated
Oct 17, 2025
Merged

Revert "Check addons subscription only if any addon is activated"#22655
thijsoo merged 1 commit intorelease/26.2from
revert-22634-check-addons-subscription-only-if-any-addon-is-activated

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Oct 17, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 17, 2025
@thijsoo thijsoo linked an issue Oct 17, 2025 that may be closed by this pull request
@thijsoo thijsoo merged commit ce1384c into release/26.2 Oct 17, 2025
26 checks passed
@thijsoo thijsoo deleted the revert-22634-check-addons-subscription-only-if-any-addon-is-activated branch October 17, 2025 07:26
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 0ae2cb4c916f567db167b83184926be93fc9032b

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 52.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/integrations/admin/helpscout-beacon.php 0 2 0.0%
Totals Coverage Status
Change from base Build fe41b7a3c7d78e43ce4618cad309b0cfa71196ff: 0.002%
Covered Lines: 31345
Relevant Lines: 59609

💛 - Coveralls

@marinakoleva marinakoleva added this to the 26.2 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perform licenses checks only if any add-on is activated

3 participants