Skip to content

fix: Add missing blank line in changelog template for proper formatting#22665

Merged
JorPV merged 1 commit intorelease/26.3from
fix/26.3-RC-creation
Oct 21, 2025
Merged

fix: Add missing blank line in changelog template for proper formatting#22665
JorPV merged 1 commit intorelease/26.3from
fix/26.3-RC-creation

Conversation

@JorPV
Copy link
Copy Markdown
Contributor

@JorPV JorPV commented Oct 21, 2025

The newHeadertemplate was missing a blank line after the "Release date:" field, which caused the injected changelog content to be directly appended without proper spacing. This prevented the Jenkins validation from correctly detecting the changelog entry.

The fix ensures the generated changelog format matches the existing entries (e.g., 26.1.1) with proper spacing between the header and the changelog sections.

🤖 Generated with Claude Code

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes Jenkins changelog entry causing pipeline failure

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

The newHeadertemplate was missing a blank line after the "Release date:" field,
which caused the injected changelog content to be directly appended without
proper spacing. This prevented the Jenkins validation from correctly detecting
the changelog entry.

The fix ensures the generated changelog format matches the existing entries
(e.g., 26.1.1) with proper spacing between the header and the changelog sections.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@JorPV JorPV added this to the 26.3 milestone Oct 21, 2025
@JorPV JorPV added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Oct 21, 2025
@JorPV JorPV marked this pull request as ready for review October 21, 2025 14:45
@JorPV JorPV merged commit 572fc53 into release/26.3 Oct 21, 2025
20 checks passed
@JorPV JorPV deleted the fix/26.3-RC-creation branch October 21, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant