Improve performance with disabled author-archives

[vraja-pro]

Context

• In the case that author archives are disabled, the potentially-expensive author_has_public_posts_wp call can be skipped.

Summary

This PR can be summarized in the following changelog entry:

• Improves performance when author archives are disabled and an author is created. Props to ErikBrendel.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Mostly regression tests:

• In a fresh site, make sure that the Show author archives without posts in search results setting in Author archives settings is disabled
• Create an author while Yoast SEO is enabled
• Try to find an indexable for that author (search for the indexable that has object_id equal to the user ID and object_type equal to user
  • Confirm there's none
• Assign a post to that user and then re-search for an indexable for that author
  • Now you find one
• Repeat the test but now make sure that the Show author archives without posts in search results setting is enabled before creating an author
  • This time an indexable will be created even before we assign a post to that author
• Repeat the test but now make sure that the Enable author archives setting is disabled before creating an author
  • This time an indexable will never be created for that author even after we assign a post to them

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• Calculate posts of authors via the WP way #19146

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #22401

[coveralls]

Pull Request Test Coverage Report for Build 77a6270c9c6e19ce7505679e1f5e68515364f5a3

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 52.806%

---

Totals
Change from base Build fee34544afae64016963b87f2c3fda56176fa29f:	-0.5%
Covered Lines:	31497
Relevant Lines:	59816

---

💛 - Coveralls