Skip to content

Fix closing advanced tab on advanced menu selection#22681

Merged
pls78 merged 6 commits intotrunkfrom
22652-advanced-settings-collapse-after-selection
Nov 3, 2025
Merged

Fix closing advanced tab on advanced menu selection#22681
pls78 merged 6 commits intotrunkfrom
22652-advanced-settings-collapse-after-selection

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented Oct 29, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug in the Settings page where the advanced tab would close when selecting one of its options or other options after visiting the advanced tab.
  • [@yoast/ui-library 0.0.1] Adds supprt for collapsable history to the Sidebar navigation context.

Relevant technical choices:

  • The history allows the defaultOpen prop to actually function only as a default value and gives more access to manipulate the open state of a collapsable.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to Yoasy SEO -> Settings
  • Open the advanced menu and click sub items in the sidebar and check the advanced menu is not closed and you reached the right page.
  • Click on the Settings->features and click on the llms.txt card button Customize llms.txt file.
  • Check you reached to the llms.txt page and the advanced tab is open.
  • Close the Content types tab and click on other tab item.
  • Check the content type tab stays close.

For Devs:

  • Spin the ui library storybook.
  • Go to the Sidebar navigation
  • Open the console and check you get no errors.
  • Open one collapsable and click on other items and other collapsabes.
  • Check the first collapsable is still open.
Kapture.2025-10-16.at.10.52.44.mp4

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #22652

@vraja-pro vraja-pro added the changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog label Oct 29, 2025
@vraja-pro vraja-pro force-pushed the 22652-advanced-settings-collapse-after-selection branch from cb13574 to bac34f0 Compare October 29, 2025 11:26
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build b8e1df12e569bf0478ea2bdc6ce7019dedc53d80

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 53.396%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/settings/app.js 0 3 0.0%
packages/js/src/settings/components/advanced-menu.js 0 9 0.0%
Totals Coverage Status
Change from base Build c6d263007d8ea06ac20b6f2f6aecf543f699ab5c: -0.01%
Covered Lines: 32184
Relevant Lines: 60500

💛 - Coveralls

@vraja-pro vraja-pro requested a review from a team as a code owner October 31, 2025 11:18
@vraja-pro vraja-pro force-pushed the 22652-advanced-settings-collapse-after-selection branch 2 times, most recently from b150f27 to 8dd8269 Compare October 31, 2025 13:18
@vraja-pro vraja-pro force-pushed the 22652-advanced-settings-collapse-after-selection branch from 8dd8269 to 0559c08 Compare October 31, 2025 13:19
Copy link
Copy Markdown
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && Acc: ✅

@pls78 pls78 added this to the 26.4 milestone Nov 3, 2025
@pls78 pls78 merged commit e7c9643 into trunk Nov 3, 2025
21 checks passed
@pls78 pls78 deleted the 22652-advanced-settings-collapse-after-selection branch November 3, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced settings collapse after selection

3 participants