Skip to content

Add tips about addons in the FTC#22688

Merged
thijsoo merged 10 commits intotrunkfrom
enrico/ftc-experiments
Nov 4, 2025
Merged

Add tips about addons in the FTC#22688
thijsoo merged 10 commits intotrunkfrom
enrico/ftc-experiments

Conversation

@enricobattocchi
Copy link
Copy Markdown
Member

@enricobattocchi enricobattocchi commented Nov 3, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Add tips about addons in the FTC.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • This will be tested for approval by @uxkai

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • visit the FTC
  • see that the first and the last step display a new tip about how you can improve with Premium
  • see that in the second step:
    • if you set 'Organization', you get a tip about Local SEO
    • if you have WooCommerce installed, you get a tip about WooCommerce SEO

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@enricobattocchi enricobattocchi added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 3, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 87881253830ac73b08f14e7e897580ca12095dd1

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 14 (7.14%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 53.379%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/first-time-configuration/tailwind-components/base/upsell-notice.js 1 2 50.0%
packages/js/src/first-time-configuration/tailwind-components/steps/site-representation/site-representation-step.js 0 1 0.0%
packages/js/src/first-time-configuration/tailwind-components/steps/finish/finish-step.js 0 2 0.0%
src/integrations/admin/first-time-configuration-integration.php 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/first-time-configuration/tailwind-components/steps/finish/finish-step.js 1 0.0%
Totals Coverage Status
Change from base Build e7c9643eeded160b81e3e3ed6f168ba851499faa: -0.02%
Covered Lines: 32185
Relevant Lines: 60513

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes.

variant="primary"
className="yst-flex yst-items-center yst-gap-1 yst-no-underline yst-font-medium"
>
{ __( "Learn more about WooCommerce SEO", "wordpress-seo" ) }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should WooCommece SEO be an replace var?

<p className="yst-mt-4">
<Link
id="ftc-indexing-learn-more"
href={ window.wpseoFirstTimeConfigurationData.shortlinks.representationLocalLearnMore }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href={ window.wpseoFirstTimeConfigurationData.shortlinks.representationLocalLearnMore }
href={ window.wpseoFirstTimeConfigurationData.shortlinks.reprLocalLearnMore }

<p className="yst-mt-4">
<Link
id="ftc-indexing-learn-more"
href={ window.wpseoFirstTimeConfigurationData.shortlinks.representationWoocommerceLearnMore }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href={ window.wpseoFirstTimeConfigurationData.shortlinks.representationWoocommerceLearnMore }
href={ window.wpseoFirstTimeConfigurationData.shortlinks.reprWoocommerceLearnMore }

@thijsoo thijsoo added this to the 26.4 milestone Nov 4, 2025
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@thijsoo thijsoo merged commit 808e24a into trunk Nov 4, 2025
35 of 37 checks passed
@thijsoo thijsoo deleted the enrico/ftc-experiments branch November 4, 2025 12:57
@enricobattocchi enricobattocchi mentioned this pull request Mar 30, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants